Is binary equality comparison of floats correct?












7














I'm working on different memory block manipulation functions and during benchmarks I noticed, that my implementation of the IsEqualRange(double* begin1, double* end1, double* begin2, double* end2) is much faster then the std::equals(...) on MSVC and GCC as well. Further investigation showed, that doubles and floats are not block compared by memcmp, but in a for loop one by one.



In what situation does binary comparison of floats lead to incorrect result? When is it ok to binary compare (equality) array of floats/doubles? Are there other fundamental types where I shouldn't use memcmp?






c++ floating-point std







share|improve this question






















  • Related: stackoverflow.com/questions/25808445/…
    – DeiDei
    56 mins ago










  • This answer to a related question is relevant to yours
    – Basile Starynkevitch
    53 mins ago






  • 1




    @BasileStarynkevitch That is related to the nature of the floating points where not every number can be represented. Doesn't say much about the equality in binary form.
    – Zoltan Tirinda
    48 mins ago






  • 1




    Similar: stackoverflow.com/q/8044862/560648
    – Lightness Races in Orbit
    20 mins ago
















7














I'm working on different memory block manipulation functions and during benchmarks I noticed, that my implementation of the IsEqualRange(double* begin1, double* end1, double* begin2, double* end2) is much faster then the std::equals(...) on MSVC and GCC as well. Further investigation showed, that doubles and floats are not block compared by memcmp, but in a for loop one by one.



In what situation does binary comparison of floats lead to incorrect result? When is it ok to binary compare (equality) array of floats/doubles? Are there other fundamental types where I shouldn't use memcmp?






c++ floating-point std







share|improve this question






















  • Related: stackoverflow.com/questions/25808445/…
    – DeiDei
    56 mins ago










  • This answer to a related question is relevant to yours
    – Basile Starynkevitch
    53 mins ago






  • 1




    @BasileStarynkevitch That is related to the nature of the floating points where not every number can be represented. Doesn't say much about the equality in binary form.
    – Zoltan Tirinda
    48 mins ago






  • 1




    Similar: stackoverflow.com/q/8044862/560648
    – Lightness Races in Orbit
    20 mins ago














7












7








7







I'm working on different memory block manipulation functions and during benchmarks I noticed, that my implementation of the IsEqualRange(double* begin1, double* end1, double* begin2, double* end2) is much faster then the std::equals(...) on MSVC and GCC as well. Further investigation showed, that doubles and floats are not block compared by memcmp, but in a for loop one by one.



In what situation does binary comparison of floats lead to incorrect result? When is it ok to binary compare (equality) array of floats/doubles? Are there other fundamental types where I shouldn't use memcmp?






c++ floating-point std







share|improve this question













I'm working on different memory block manipulation functions and during benchmarks I noticed, that my implementation of the IsEqualRange(double* begin1, double* end1, double* begin2, double* end2) is much faster then the std::equals(...) on MSVC and GCC as well. Further investigation showed, that doubles and floats are not block compared by memcmp, but in a for loop one by one.



In what situation does binary comparison of floats lead to incorrect result? When is it ok to binary compare (equality) array of floats/doubles? Are there other fundamental types where I shouldn't use memcmp?






c++ floating-point std




c++ floating-point std






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked 59 mins ago









Zoltan Tirinda

361419




361419












  • Related: stackoverflow.com/questions/25808445/…
    – DeiDei
    56 mins ago










  • This answer to a related question is relevant to yours
    – Basile Starynkevitch
    53 mins ago






  • 1




    @BasileStarynkevitch That is related to the nature of the floating points where not every number can be represented. Doesn't say much about the equality in binary form.
    – Zoltan Tirinda
    48 mins ago






  • 1




    Similar: stackoverflow.com/q/8044862/560648
    – Lightness Races in Orbit
    20 mins ago


















  • Related: stackoverflow.com/questions/25808445/…
    – DeiDei
    56 mins ago










  • This answer to a related question is relevant to yours
    – Basile Starynkevitch
    53 mins ago






  • 1




    @BasileStarynkevitch That is related to the nature of the floating points where not every number can be represented. Doesn't say much about the equality in binary form.
    – Zoltan Tirinda
    48 mins ago






  • 1




    Similar: stackoverflow.com/q/8044862/560648
    – Lightness Races in Orbit
    20 mins ago
















Related: stackoverflow.com/questions/25808445/…
– DeiDei
56 mins ago




Related: stackoverflow.com/questions/25808445/…
– DeiDei
56 mins ago












This answer to a related question is relevant to yours
– Basile Starynkevitch
53 mins ago




This answer to a related question is relevant to yours
– Basile Starynkevitch
53 mins ago




1




1




@BasileStarynkevitch That is related to the nature of the floating points where not every number can be represented. Doesn't say much about the equality in binary form.
– Zoltan Tirinda
48 mins ago




@BasileStarynkevitch That is related to the nature of the floating points where not every number can be represented. Doesn't say much about the equality in binary form.
– Zoltan Tirinda
48 mins ago




1




1




Similar: stackoverflow.com/q/8044862/560648
– Lightness Races in Orbit
20 mins ago




Similar: stackoverflow.com/q/8044862/560648
– Lightness Races in Orbit
20 mins ago












2 Answers
2






active

oldest

votes


















14














The first thing I would do if I were you is to check your optimisation settings.



It's fine to use memcmp for an array of floating points but note that you could get different results to element-by-element ==:




  1. +0.0 is defined to compare equal to -0.0.


  2. NaN is defined to compare not-equal to NaN.







share|improve this answer





























    2














    The main issue is nan values, as these are never equal to themselves. So strictly speaking, you cannot use memcmp for them, as the answer would be mathematically incorrect.



    If you know that you don't have nan values, then you can use memcmp.






    share|improve this answer





















      Your Answer






      StackExchange.ifUsing("editor", function () {
      StackExchange.using("externalEditor", function () {
      StackExchange.using("snippets", function () {
      StackExchange.snippets.init();
      });
      });
      }, "code-snippets");

      StackExchange.ready(function() {
      var channelOptions = {
      tags: "".split(" "),
      id: "1"
      };
      initTagRenderer("".split(" "), "".split(" "), channelOptions);

      StackExchange.using("externalEditor", function() {
      // Have to fire editor after snippets, if snippets enabled
      if (StackExchange.settings.snippets.snippetsEnabled) {
      StackExchange.using("snippets", function() {
      createEditor();
      });
      }
      else {
      createEditor();
      }
      });

      function createEditor() {
      StackExchange.prepareEditor({
      heartbeatType: 'answer',
      autoActivateHeartbeat: false,
      convertImagesToLinks: true,
      noModals: true,
      showLowRepImageUploadWarning: true,
      reputationToPostImages: 10,
      bindNavPrevention: true,
      postfix: "",
      imageUploader: {
      brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
      contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
      allowUrls: true
      },
      onDemand: true,
      discardSelector: ".discard-answer"
      ,immediatelyShowMarkdownHelp:true
      });


      }
      });














      draft saved

      draft discarded


















      StackExchange.ready(
      function () {
      StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54020760%2fis-binary-equality-comparison-of-floats-correct%23new-answer', 'question_page');
      }
      );

      Post as a guest















      Required, but never shown

























      2 Answers
      2






      active

      oldest

      votes








      2 Answers
      2






      active

      oldest

      votes









      active

      oldest

      votes






      active

      oldest

      votes









      14














      The first thing I would do if I were you is to check your optimisation settings.



      It's fine to use memcmp for an array of floating points but note that you could get different results to element-by-element ==:




      1. +0.0 is defined to compare equal to -0.0.


      2. NaN is defined to compare not-equal to NaN.







      share|improve this answer


























        14














        The first thing I would do if I were you is to check your optimisation settings.



        It's fine to use memcmp for an array of floating points but note that you could get different results to element-by-element ==:




        1. +0.0 is defined to compare equal to -0.0.


        2. NaN is defined to compare not-equal to NaN.







        share|improve this answer
























          14












          14








          14






          The first thing I would do if I were you is to check your optimisation settings.



          It's fine to use memcmp for an array of floating points but note that you could get different results to element-by-element ==:




          1. +0.0 is defined to compare equal to -0.0.


          2. NaN is defined to compare not-equal to NaN.







          share|improve this answer












          The first thing I would do if I were you is to check your optimisation settings.



          It's fine to use memcmp for an array of floating points but note that you could get different results to element-by-element ==:




          1. +0.0 is defined to compare equal to -0.0.


          2. NaN is defined to compare not-equal to NaN.








          share|improve this answer












          share|improve this answer



          share|improve this answer










          answered 56 mins ago









          Bathsheba

          175k27247371




          175k27247371

























              2














              The main issue is nan values, as these are never equal to themselves. So strictly speaking, you cannot use memcmp for them, as the answer would be mathematically incorrect.



              If you know that you don't have nan values, then you can use memcmp.






              share|improve this answer


























                2














                The main issue is nan values, as these are never equal to themselves. So strictly speaking, you cannot use memcmp for them, as the answer would be mathematically incorrect.



                If you know that you don't have nan values, then you can use memcmp.






                share|improve this answer
























                  2












                  2








                  2






                  The main issue is nan values, as these are never equal to themselves. So strictly speaking, you cannot use memcmp for them, as the answer would be mathematically incorrect.



                  If you know that you don't have nan values, then you can use memcmp.






                  share|improve this answer












                  The main issue is nan values, as these are never equal to themselves. So strictly speaking, you cannot use memcmp for them, as the answer would be mathematically incorrect.



                  If you know that you don't have nan values, then you can use memcmp.







                  share|improve this answer












                  share|improve this answer



                  share|improve this answer










                  answered 56 mins ago









                  Matthieu Brucher

                  12.2k22139




                  12.2k22139






























                      draft saved

                      draft discarded




















































                      Thanks for contributing an answer to Stack Overflow!


                      • Please be sure to answer the question. Provide details and share your research!

                      But avoid …



                      • Asking for help, clarification, or responding to other answers.

                      • Making statements based on opinion; back them up with references or personal experience.


                      To learn more, see our tips on writing great answers.





                      Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


                      Please pay close attention to the following guidance:


                      • Please be sure to answer the question. Provide details and share your research!

                      But avoid …



                      • Asking for help, clarification, or responding to other answers.

                      • Making statements based on opinion; back them up with references or personal experience.


                      To learn more, see our tips on writing great answers.




                      draft saved


                      draft discarded














                      StackExchange.ready(
                      function () {
                      StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54020760%2fis-binary-equality-comparison-of-floats-correct%23new-answer', 'question_page');
                      }
                      );

                      Post as a guest















                      Required, but never shown





















































                      Required, but never shown














                      Required, but never shown












                      Required, but never shown







                      Required, but never shown

































                      Required, but never shown














                      Required, but never shown












                      Required, but never shown







                      Required, but never shown







                      -

                      Popular posts from this blog

                      Understanding the information contained in the Deep Space Network XML data?

                      Image
                      up vote 1 down vote favorite NASA's Deep Space Network activity can be viewed conveniently at https://eyes.nasa.gov/dsn/dsn.html but if you would like data in a more raw XML form, it can be accessed as described in this answer Below is a small Python script that reads the XML into a list of dictionaries, and saves it to disk as a JSON. The dictionaries are organized at the higher level by dish, then by spacecraft per dish. Question: What are the most-likely meanings of all the data field contained in the Deep Space Network XML data? This is the example url from the other answer, used in the script below: https://eyes.nasa.gov/dsn/data/1365107113.xml def dictify(r,root=True): # https://stackoverflow.com/questions/2148119/how-to-convert-an-xml-string-to-a-dictionary-in-python/30923963#30923963 if root: ret
                      Read more

                      Ross-on-Wye

                      Image
                      Ross-on-Wye Welsh: Rhosan ar Wy Town centre, looking north from Market House Ross-on-Wye Ross-on-Wye shown within Herefordshire Population 10,700 (2011) [1] OS grid reference SO597241 Unitary authority Herefordshire Ceremonial county Herefordshire Region West Midlands Country England Sovereign state United Kingdom Post town ROSS-ON-WYE Postcode district HR9 Dialling code 01989 Police West Mercia Fire Hereford and Worcester Ambulance West Midlands EU Parliament West Midlands UK Parliament Hereford and South Herefordshire List of places UK England Herefordshire 51°54′50″N 2°35′13″W  /  51.914°N 2.587°W  / 51.914; -2.587 Coordinates: 51°54′50″N 2°35′13″W  /  51.914°N 2.587°W  / 51.914; -2.587 Ross-on-Wye (Welsh: Rhosan ar Wy [2] ) is a small market town with a population of 10,700 (according to the 2011 census), in south eastern Herefordshire, England, located on the River Wye, and on
                      Read more

                      Eastern Orthodox Church

                      Image
                      Not to be confused with Oriental Orthodoxy, Eastern Christianity, or Eastern Catholic Churches. "Eastern Orthodoxy", "Orthodox Church", "Orthodox Catholic Church", and "Orthodox Christian Church" redirect here. For other uses, see Orthodox (disambiguation). This article may be too long to read and navigate comfortably . The readable prose size is 132 kilobytes. Please consider splitting content into sub-articles, condensing it, or adding or removing subheadings. ( January 2018 ) Part of a series on the Eastern Orthodox Church Mosaic of Christ Pantocrator, Hagia Sophia Overview Structure Theology (History of theology) Liturgy Church history Holy Mysteries View of salvation View of Mary View of icons Background Crucifixion / Resurrection / Ascension of Jesus Christianity Christian Church Apostolic succession Four Marks of the Church Orthodoxy Organization Autocephaly Patriarchate
                      Read more